Coerce None values into strings in logentry params. #4121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4121 +/- ##
==========================================
+ Coverage 79.49% 79.56% +0.07%
==========================================
Files 140 140
Lines 15624 15624
Branches 2650 2651 +1
==========================================
+ Hits 12420 12431 +11
+ Misses 2369 2360 -9
+ Partials 835 833 -2
|
sentrivana
approved these changes
Mar 10, 2025
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
Nice.
Some tests also need updating, it seems. It'd also be great to have a test case for the None case specifically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice rendering of log messages containing parameters that are
Nonevalues does not work. There we coerceNonevalues into strings to have nicer messages in Sentry UI.Fixes #3660